Skip to content

feat: switch hash to faster #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: austin/chore_formatting_cleanup_types
Choose a base branch
from
Draft

feat: switch hash to faster #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dune-project
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
(package
(name pyro-caml-instruments)
(synopsis "Pyroscope + OCaml = Pyro Caml")
(depends ocaml logs digestif ppx_deriving)
(depends ocaml logs containers ppx_deriving)
(tags ("profiling")))

(package
Expand Down
6 changes: 3 additions & 3 deletions lib/Event.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
(* Event *)
(*****************************************************************************)
(* md5 feels fast and safe enough *)
module Hash = Digest.MD5
module Hash = CCHash

(* an event is either a point or partial. We have a notion of a partial event
since runtime events only support payloads of max 1024 bytes, and any larger
Expand All @@ -26,7 +26,7 @@ module Hash = Digest.MD5
profiler *)
type t =
| Point of (float * Stack_trace.raw_stack_trace)
| Partial of { id : Hash.t; bytes : Bytes.t; part : int; part_count : int }
| Partial of { id : int; bytes : Bytes.t; part : int; part_count : int }

type marshaled = bytes * int

Expand Down Expand Up @@ -91,7 +91,7 @@ let emit_event e =
[@@inline always]

(* buffer for storing partial events so we can then rebuild them *)
type event_buffer = (Hash.t, (int * Bytes.t) list) Hashtbl.t
type event_buffer = (int, (int * Bytes.t) list) Hashtbl.t

(* event_of_perf event will keep track of partial events and spit them out as
normal events if it finds all the parts *)
Expand Down
2 changes: 1 addition & 1 deletion lib/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
(library
(name pyro_caml_instruments)
(public_name pyro-caml-instruments)
(libraries runtime_events unix logs digestif)
(libraries runtime_events unix logs containers)
(preprocess
(pps ppx_deriving.eq))
(instrumentation.backend
Expand Down
2 changes: 1 addition & 1 deletion pyro-caml-instruments.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ depends: [
"dune" {>= "3.20"}
"ocaml"
"logs"
"digestif"
"containers"
"ppx_deriving"
"odoc" {with-doc}
]
Expand Down