exception when using socket as gnss source

[divenal]

I'm getting a KeyError: 'serial_settings' from stream_handler.py when trying to use a socket as gnss source. Approx line 124 but I may have added some debug prints.

The problem seems to be that the access of settings["serial_settings"] has been moved from within the CONNECTED-specific code up a few lines. I'm guessing that when conntype is CONNECTED_SOCKET, settings doesn't have any "serial_settings".

Looks like it happened in 42e2ae0 "Merge branch 'ubx_simulation' into RC-1.4.10 "

[semuadmin]

Can you provide the full error trace back please? Thanks

[divenal]

$ ./venvs/pygps/bin/pygpsclient
Exception in thread Thread-1 (_read_thread):
Traceback (most recent call last):
File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
self.run()
File "/usr/lib/python3.11/threading.py", line 975, in run
self._target(*self._args, **self._kwargs)
File "/home/drd/venvs/pygps/lib/python3.11/site-packages/pygpsclient/stream_handler.py", line 124, in _read_thread
ser = settings["serial_settings"]
~~~~~~~~^^^^^^^^^^^^^^^^^^^
KeyError: 'serial_settings'

[semuadmin]

Ta. On it.

[divenal]

There's a similar problem when trying to use l-band spartn corrections:

$ ./venvs/pygps/bin/pygpsclient
Exception in thread Thread-4 (_read_thread):
Traceback (most recent call last):
File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
self.run()
File "/usr/lib/python3.11/threading.py", line 975, in run
self._target(*self._args, **self._kwargs)
File "/home/drd/venvs/pygps/lib/python3.11/site-packages/pygpsclient/stream_handler.py", line 120, in _read_thread
inactivity_timeout = settings["inactivity_timeout"]
~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'inactivity_timeout'

It looks like the code that launches the reader thread doesn't provide an inactivity timeout in on_connect() in spartn_lband_frame.py

(That might have been on version 1.4.9 since I installed an older version to get around the first problem.)

[semuadmin]

Hi @divenal

Should both be sorted in v1.4.12. Thanks for the shout.