Skip to content

Commit fe89258

Browse files
Fixed parsing problem with msedgedriver version in release notes (SeleniumHQ#1657)
Fixed parsing problem with msedgedriver version in release notes generator script and docker image tagging script.
1 parent 46716f5 commit fe89258

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

generate_release_notes.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ git --no-pager log "${LATEST_TAG}...${HEAD_BRANCH}" --pretty=format:"* [\`%h\`](
1414
CHROME_VERSION=$(docker run --rm selenium/node-chrome:${TAG_VERSION} google-chrome --version | awk '{print $3}')
1515
EDGE_VERSION=$(docker run --rm selenium/node-edge:${TAG_VERSION} microsoft-edge --version | awk '{print $3}')
1616
CHROMEDRIVER_VERSION=$(docker run --rm selenium/node-chrome:${TAG_VERSION} chromedriver --version | awk '{print $2}')
17-
EDGEDRIVER_VERSION=$(docker run --rm selenium/node-edge:${TAG_VERSION} msedgedriver --version | awk '{print $2}')
17+
EDGEDRIVER_VERSION=$(docker run --rm selenium/node-edge:${TAG_VERSION} msedgedriver --version | awk '{print $4}')
1818
FIREFOX_VERSION=$(docker run --rm selenium/node-firefox:${TAG_VERSION} firefox --version | awk '{print $3}')
1919
GECKODRIVER_VERSION=$(docker run --rm selenium/node-firefox:${TAG_VERSION} geckodriver --version | awk 'NR==1{print $2}')
2020
FFMPEG_VERSION=$(docker run --entrypoint="" --rm selenium/video:ffmpeg-4.3.1-${BUILD_DATE} ffmpeg -version | awk '{print $3}' | head -n 1)

tag_and_push_browser_images.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ edge)
6969
EDGE_SHORT_VERSION="$(short_version ${EDGE_VERSION})"
7070
echo "Short Edge version -> "${EDGE_SHORT_VERSION}
7171

72-
EDGEDRIVER_VERSION=$(docker run --rm selenium/node-edge:${TAG_VERSION} msedgedriver --version | awk '{print $2}')
72+
EDGEDRIVER_VERSION=$(docker run --rm selenium/node-edge:${TAG_VERSION} msedgedriver --version | awk '{print $4}')
7373
echo "EdgeDriver version -> "${EDGEDRIVER_VERSION}
7474
EDGEDRIVER_SHORT_VERSION="$(short_version ${EDGEDRIVER_VERSION})"
7575
echo "Short EdgeDriver version -> "${EDGEDRIVER_SHORT_VERSION}

0 commit comments

Comments
 (0)