Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding un-silenced events does not seem to work #279

Open
echlebek opened this issue Mar 26, 2020 · 2 comments
Open

Hiding un-silenced events does not seem to work #279

echlebek opened this issue Mar 26, 2020 · 2 comments
Labels
component:web-ui issue: bug Something isn't working

Comments

@echlebek
Copy link
Contributor

Expected Behavior

Hiding un-silenced events will show all silenced events, and no other events.

Current Behavior

All events are hidden.

Possible Solution

?

Steps to Reproduce

  1. In the web UI, silence an event, and then click "hide all un-silenced".

Context

QA. This only happened for a little while, and then the bug stopped reproducing. :(

@echlebek echlebek added issue: bug Something isn't working component:web-ui labels Mar 26, 2020
@nikkictl
Copy link

This bug sounds like its difficult to reproduce, we'll keep this open in case we encounter it again in QA or otherwise.

@jamesdphillips
Copy link
Contributor

jamesdphillips commented May 6, 2020

https://github.com/sensu/sensu-go/blob/master/backend/apid/graphql/event_filters.go#L37-L40

The silence filter works by using the silenced field on the check type, this means that it is filtering events that were silenced* and not by the presence of a silence. The easiest solution may be to improve communication so that expectations are set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:web-ui issue: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants