Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom exception for entity cannot be created or deleted #15

Closed
ejseqera opened this issue Jul 20, 2023 · 1 comment
Closed

Fix custom exception for entity cannot be created or deleted #15

ejseqera opened this issue Jul 20, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ejseqera
Copy link
Member

Right now, when you fail to create a resource, we raise:

tw_pywrap.tower.ResourceCreationError:  Resource creation failed with the following error:

However, this is also thrown in an example where you fail to delete something (i.e. it already exists and you don't have the permissions to delete it)

We could change this to throw ResourceModificationError maybe?
@ejseqera ejseqera added the bug Something isn't working label Jul 21, 2023
@ejseqera
Copy link
Member Author

Fixed in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ejseqera