-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using multiple paragraphs instead of multiple inlines in a single paragraph #11
Comments
Hi @augustoproiete -
|
@TonyValenti Very interesting ideas. Tracking via #15 and #16 to discuss design. They could potentially be done independently of this issue though definitely related |
Any chance you could give me a quote on getting this work done? |
We are having performance problems with longer running apps because this is not implemented. Any chance you can make it happen soon? |
@TonyValenti I'll see if I can block some time over the next few weeks, but happy to take a PR if you'd like to give it a go |
Any update for this? |
I have code that does this and makes the library much more performant but the manager has stopped replying. |
Currently, each new log entry appends a corresponding
Inline
object to the lastParagraph
in the RichTextBox.One user reported that writing log entries creating multiple paragraphs seem to have a better performance than creating multiple inlines in a single paragraph once the number of entries is large (the example was ~6000 lines with 4-5 tokens in each entry).
If that is true (needs testing/PoC), then it probably makes sense to switch to using multiple paragraphs by default.
One downside of using multiple paragraphs is that by default the control appends a margin which visually looks like each entry is using two lines instead of one, thus the user would have to remove the default margin of the control:
I don't think the sink should be making any changes to the visual aspects of the RichTextBox control, thus if we go this route, we should document the margin issue above
The text was updated successfully, but these errors were encountered: