Ensure exception gets logged when CustomErrors mode is On (#13)

Ensure exception gets logged when CustomErrors mode is On

Co-authored-by: Twan Jacobs <tjacobs@routit.com>

Author: tsimbalar

src/SerilogWeb.Classic.Mvc/Classic/Mvc/PreApplicationStartModule.cs

@@ -7,6 +7,7 @@ public class PreApplicationStartModule
         public static void Register()
         {
             GlobalFilters.Filters.Add(new StoreMvcInfoInHttpContextActionFilter());
+            GlobalFilters.Filters.Add(new SerilogWebClassicExceptionFilter());
         }
     }
 }

src/SerilogWeb.Classic.Mvc/Classic/Mvc/SerilogWebClassicExceptionFilter.cs

@@ -0,0 +1,21 @@
+using System;
+using System.Web.Mvc;
+using SerilogWeb.Classic.Extensions;
+
+namespace SerilogWeb.Classic.Mvc
+{
+    internal class SerilogWebClassicExceptionFilter : IExceptionFilter
+    {
+        public void OnException(ExceptionContext filterContext)
+        {
+            if (filterContext.ExceptionHandled || filterContext.HttpContext.IsCustomErrorEnabled)
+            {
+                var exception = filterContext.Exception;
+                if (exception != null)
+                {
+                    filterContext.HttpContext.AddSerilogWebError(exception);
+                }
+            }
+        }
+    }
+}

src/SerilogWeb.Classic.Mvc/SerilogWeb.Classic.Mvc.csproj

@@ -44,7 +44,7 @@
       <HintPath>..\..\packages\Serilog.2.7.1\lib\net45\Serilog.dll</HintPath>
     </Reference>
     <Reference Include="SerilogWeb.Classic, Version=5.0.0.0, Culture=neutral, PublicKeyToken=9462ddd55fbc0e7f, processorArchitecture=MSIL">
-      <HintPath>..\..\packages\SerilogWeb.Classic.5.0.48\lib\net45\SerilogWeb.Classic.dll</HintPath>
+      <HintPath>..\..\packages\SerilogWeb.Classic.5.0.52\lib\net45\SerilogWeb.Classic.dll</HintPath>
     </Reference>
     <Reference Include="System" />
     <Reference Include="System.Core" />
@@ -85,6 +85,7 @@
     <Compile Include="Classic\Mvc\Enrichers\MvcRouteDataEnricher.cs" />
     <Compile Include="Classic\Mvc\Enrichers\MvcRouteTemplateEnricher.cs" />
     <Compile Include="Classic\Mvc\PreApplicationStartModule.cs" />
+    <Compile Include="Classic\Mvc\SerilogWebClassicExceptionFilter.cs" />
     <Compile Include="Classic\Mvc\StoreMvcInfoInHttpContextActionFilter.cs" />
     <Compile Include="Classic\Mvc\MvcRequestInfoKey.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />

src/SerilogWeb.Classic.Mvc/packages.config

@@ -5,5 +5,5 @@
   <package id="Microsoft.AspNet.WebPages" version="3.2.3" targetFramework="net45" />
   <package id="Microsoft.Web.Infrastructure" version="1.0.0.0" targetFramework="net45" />
   <package id="Serilog" version="2.7.1" targetFramework="net45" />
-  <package id="SerilogWeb.Classic" version="5.0.48" targetFramework="net45" />
+  <package id="SerilogWeb.Classic" version="5.0.52" targetFramework="net45" />
 </packages>

test/SerilogWeb.Classic.Mvc.Test/SerilogWeb.Classic.Mvc.Test.csproj

@@ -71,7 +71,7 @@
       <HintPath>..\..\packages\Serilog.Sinks.Trace.2.1.0\lib\net45\Serilog.Sinks.Trace.dll</HintPath>
     </Reference>
     <Reference Include="SerilogWeb.Classic, Version=5.0.0.0, Culture=neutral, PublicKeyToken=9462ddd55fbc0e7f, processorArchitecture=MSIL">
-      <HintPath>..\..\packages\SerilogWeb.Classic.5.0.48\lib\net45\SerilogWeb.Classic.dll</HintPath>
+      <HintPath>..\..\packages\SerilogWeb.Classic.5.0.52\lib\net45\SerilogWeb.Classic.dll</HintPath>
     </Reference>
     <Reference Include="System" />
     <Reference Include="System.Data" />

test/SerilogWeb.Classic.Mvc.Test/packages.config

@@ -18,6 +18,6 @@
   <package id="Serilog" version="2.7.1" targetFramework="net45" />
   <package id="Serilog.Settings.AppSettings" version="2.1.2" targetFramework="net45" />
   <package id="Serilog.Sinks.Trace" version="2.1.0" targetFramework="net45" />
-  <package id="SerilogWeb.Classic" version="5.0.48" targetFramework="net45" />
+  <package id="SerilogWeb.Classic" version="5.0.52" targetFramework="net45" />
   <package id="WebGrease" version="1.5.2" targetFramework="net45" />
 </packages>