You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 1, 2020. It is now read-only.
@eahefnawy yeah, it is problem unfortunately :( Without this crazy Proxy thing, when the CLI tries to fetch a custom method on a Template instance - it will fail.
I totally agree this Proxy thing is far from ideal. Since Template is so baked in at the CLI level, maybe it should have something like hasMethod(method) and executeMethod(method) which would be called by CLI? Then we could remove this Proxy voodoo. it would only require a small change to the CLI in case of a Template component, and a small addition to Template component only, and the Proxy thing would be gone.
Also, I suggest maybe we should remove this custom method feature until better times.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Access of any core property (as
hasOwnProperty
) or not existing property returns a method as generated bycreateCustomMethodHandler
This may turn nasty, when we pass such object to any generic util, or if any developer decides to handle it in some outer module.
It's caused by optimistic Proxy setup:
template/serverless.js
Line 31 in fdc1924
The text was updated successfully, but these errors were encountered: