Skip to content

Commit

Permalink
Removed 'if' check in release-package job, removed debug output and u…
Browse files Browse the repository at this point in the history
…pdated README.md
  • Loading branch information
stephenhand committed Jul 5, 2021
1 parent a18d5a0 commit d2be914
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 14 deletions.
12 changes: 1 addition & 11 deletions .github/workflows/release-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ env:

jobs:
release-serviurtium-core:
if: ${{ contains(github.ref, 'refs/tags/servirtium.core/v') }}
runs-on: ubuntu-latest

steps:
Expand All @@ -27,20 +26,11 @@ jobs:
- name: Test
run: dotnet test --no-restore --verbosity normal

# - name: Determine Version
# uses: paulhatch/semantic-version@v4.0.2
# id: semantic_version
# with:
# format: "${major}.${minor}.${patch}-dev.{increment}"

- uses: nuget/setup-nuget@v1
with:
nuget-api-key: ${{ secrets.NuGetAPIKey }}
nuget-version: '5.x'
- name: Dump GitHub context
env:
GITHUB_CONTEXT: ${{ toJSON(github) }}
run: echo "$GITHUB_CONTEXT"

- name: Extract version from ref
uses: actions/github-script@v4
id: extract-version
Expand Down
24 changes: 21 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ See `deploy_local_nuget.sh `
## Published NuGet assemblies
* [Servirtium.Core/1.0.0](https://www.nuget.org/packages/Servirtium.Core/1.0.0)
* [Servirtium.AspNetCore/1.0.0](https://www.nuget.org/packages/Servirtium.AspNetCore/1.0.0)
* [Servirtium.Core/1.3.0](https://www.nuget.org/packages/Servirtium.Core/1.3.0)
* [Servirtium.AspNetCore/1.3.0](https://www.nuget.org/packages/Servirtium.AspNetCore/1.3.0)
## Current Status
Expand All @@ -104,4 +104,22 @@ Current roadmap in priority order:
## Confirming compatability with other implementations
Read about the [compatibility suite](COMPATIBILITY_SUITE.md) for this .NET implementation
Read about the [compatibility suite](COMPATIBILITY_SUITE.md) for this .NET implementation
## Releasing New Versions
Releases are pushed using the `release-package.yml` Github action, which is triggered by creating a Github release
To publish a new version of the Servirtium.Core package:
1. Create & Publish a new Github release from the web UI, with the tag Servirtium.Core/v<semver2-version> - the tag can be created in advance or be new as part of the release, but the package will only be pushed when a release is created in either case.
2. The release-package.yml workflow should pick up this new release and push a nuget package.
To publish a new version of the Servirtium.AspNetCore package:
1. Create & Publish a new Github release from the web UI, with the tag Servirtium.AspNetCore/v<semver2-version> - the tag can be created in advance or be new as part of the release, but the package will only be pushed when a release is created in either case.
2. The release-package.yml workflow should pick up this new release and push a nuget package.
The release-package.yml workflow is generic, it will publish any package you name prior to the forward slash, provided there is a directory in the root of the source with that name containing a csproj file with the same name.
e.g. You could create a release tagged `Apoplectic.Turkeys/v1.2.3` - if there is a project at `/Apoplectic.Turkeys/Apoplectic.Turkeys.csproj` in the source, it will pack and push package Apoplectic.Turkeys version 1.2.3. Otherwise the workflow will fail and nothing will happen

0 comments on commit d2be914

Please sign in to comment.