fix(charts): update values.yaml and job.yaml for chainId and security context

- Added chainId field to values.yaml for explicit configuration.
- Updated comments in values.yaml for clarity and compatibility with helm-docs.
- Adjusted job.yaml to ensure proper handling of chainId and security contexts.
- Addressed YAML parse errors in job.yaml to maintain template integrity.

Author: roderik

charts/network/README.md

@@ -22,8 +22,8 @@ A Helm chart for a blockchain network on Kubernetes
 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
 | extraInitContainers | list | `[]` | Additional init containers appended verbatim to each workload. |
-| global | object | `{"chainId":null,"networkNodes":{"faucetArtifactPrefix":"besu-faucet","genesisConfigMapName":"besu-genesis","podPrefix":"","serviceName":"","staticNodesConfigMapName":"besu-static-nodes"},"securityContexts":{"container":{},"pod":{}}}` | Global configuration shared across subcharts. |
-| global.chainId | int | `nil` | Chain ID applied when charts omit explicit overrides. |
+| global | object | `{"chainId":13456,"networkNodes":{"faucetArtifactPrefix":"besu-faucet","genesisConfigMapName":"besu-genesis","podPrefix":"","serviceName":"","staticNodesConfigMapName":"besu-static-nodes"},"securityContexts":{"container":{},"pod":{}}}` | Global configuration shared across subcharts. |
+| global.chainId | int | `13456` | Chain ID applied when charts omit explicit overrides. |
 | global.networkNodes | object | `{"faucetArtifactPrefix":"besu-faucet","genesisConfigMapName":"besu-genesis","podPrefix":"","serviceName":"","staticNodesConfigMapName":"besu-static-nodes"}` | Defaults consumed by Besu network node workloads. |
 | global.networkNodes.faucetArtifactPrefix | string | `"besu-faucet"` | Prefix used for faucet ConfigMaps and Secrets. |
 | global.networkNodes.genesisConfigMapName | string | `"besu-genesis"` | ConfigMap name storing the generated genesis.json artifact. |

charts/network/charts/network-bootstrapper/templates/job.yaml

@@ -71,8 +71,10 @@ spec:
             {{- $globalNodes := default (dict) (get $globalValues "networkNodes") }}
             {{- $localChainId := get $settingsValues "chainId" }}
             {{- $globalChainId := get $globalValues "chainId" }}
-            {{- $localChainIdSet := not (kindIs "invalid" $localChainId) }}
-            {{- $globalChainIdSet := not (kindIs "invalid" $globalChainId) }}
+            {{- $localChainIdBlank := and (kindIs "string" $localChainId) (eq (trim $localChainId) "") }}
+            {{- $globalChainIdBlank := and (kindIs "string" $globalChainId) (eq (trim $globalChainId) "") }}
+            {{- $localChainIdSet := and (not (kindIs "invalid" $localChainId)) (not $localChainIdBlank) (not (empty $localChainId)) }}
+            {{- $globalChainIdSet := and (not (kindIs "invalid" $globalChainId)) (not $globalChainIdBlank) (not (empty $globalChainId)) }}
             {{- $resolvedChainId := ternary $localChainId $globalChainId $localChainIdSet }}
             {{- $autoNames := dict "service" "besu-node" "podPrefix" "besu-node-validator" }}
             {{- with (index $.Subcharts "network-nodes") }}

charts/network/values.yaml

@@ -15,7 +15,7 @@ global:
     # -- (string) Prefix used for faucet ConfigMaps and Secrets.
     faucetArtifactPrefix: besu-faucet
   # -- (int) Chain ID applied when charts omit explicit overrides.
-  chainId:
+  chainId: 13456
   # -- (object) Shared pod- and container-level security contexts applied when subcharts omit explicit overrides.
   securityContexts:
     # -- (object) Pod security context inherited by subcharts when set.