-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a superuser/admin with an UI to manage both CM and Para #451
Comments
@canjalal to elaboate on this ticket and work together with Thom. This is higher priority than the other tickets on the board. We need to get this out before we are able to test and develop the other [Para] tickets |
So regarding impersonation, I recommend that be an admin feature. So no one can impersonate admin, but admins can impersonate any other role. We can put a drop-down on the settings page that allows admins to set their role temporarily for the session. To regain admin, they would need to logout/in. |
This ticket has a dependency on #452 |
I have the admin UI part of this working, preparing for code-cleanup prior to code review. @tam-janice @nickvisut @francisli @canjalal. It has:
TBD:
|
check out feat/admin-panel if you want to see the code, but it's at the 'ai did a lot of this' stage, prior to me cleaning it up |
Wow thanks for the pagination! I think the admin user who is logged in should be able to see themselves but not be able to change their own role, otherwise this could cause problems. They could be grayed out for example. There should be testing to ensure this is enforced both at the frontend and at the backend. I think the delete/archive decision is complicated. Because as you said, we could lose data if we outright delete, but there could be security problems if we don't delete and just archive. I am currently working on a PR to add storybook testing on frontend components |
…#474) * basic user table working with sort and search and pagination all handled back-end * feat: adding users * fix: types * feat: edit users * feat: edit user, role dropdown * fix: styling + search query counts/pagination * fix: styling * fix: role init + sharing types backend/frontend * fix: lint * feat: better error handling ux + toas fixes * fix: table2 refactor + breadcrumb + linting * fix: prettier * fix: prettier * fix: types * fix: some cleanup + user can't edit their own role * fix: rename new table * fix: code cleanup + case handling of roles cleaned up * fix: unused import * Fix lint errors --------- Co-authored-by: Francis Li <francisli@users.noreply.github.com> Co-authored-by: Francis Li <mail@francisli.com>
Related to #452 . We want users in the admin user role to be able to change the user role of every other user, and have a way to do it on the frontend. This will necessitate the creation of an Admin user page with a list of all users, and controller actions that will patch the user to change their role and/or delete them.
A related issue (see below) is creating a small number of users who can log in with username and password without OAuth, for ease of testing.
Notes
Per @nickvisut
would be cool tho to “impersonate” roles as admin for sure tho,
@Vincent Shuali
NEW
7:23
I think these are separate issues:
Adding impersonation via admin
Working roles/UI
being able to log in as para
another login auth
The text was updated successfully, but these errors were encountered: