Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a pydantic model to be used with self.generate #64

Open
sgbaird opened this issue Aug 16, 2024 · 0 comments
Open

Allow for a pydantic model to be used with self.generate #64

sgbaird opened this issue Aug 16, 2024 · 0 comments

Comments

@sgbaird
Copy link
Owner

sgbaird commented Aug 16, 2024

As-is, the selections arg of Honegumi().generate(...) isn't really bounded; however, it's going to be very specific to the package. For example, Ax will assume selections is a dictionary of a specific format. Pydantic works well in these scenarios, and may be justified here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant