Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrity tests needed for dencode #138

Closed
jeromekelleher opened this issue Apr 24, 2024 · 6 comments
Closed

Integrity tests needed for dencode #138

jeromekelleher opened this issue Apr 24, 2024 · 6 comments

Comments

@jeromekelleher
Copy link
Contributor

#136 added the distributed encode operation, but only with very basic tests to check things work in the nominal case.

Needs some tests to be sure we do the right thing when things go wrong.

@benjeffery
Copy link
Contributor

On this theme - currently if a partition is missing due to job failure, finialise will error out, running the failed job and then finalising again errors as finalise already moved things around.

@jeromekelleher
Copy link
Contributor Author

jeromekelleher commented Apr 25, 2024

Should finalise try to check if everything is present first? This means looking at each array in each partition, so O(10000) directory check operations. This is probably simpler than trying to make finalise robust to making multiple passes, but is ultimately less robust I guess.

@benjeffery
Copy link
Contributor

Checking that each partition is present and that there are no wip arrays should be the equivalent of O(partitions) ls operations, which I think is doable?

@jeromekelleher
Copy link
Contributor Author

Ok, let's try that in the first instance

@jeromekelleher
Copy link
Contributor Author

I'll code it up later

@jeromekelleher
Copy link
Contributor Author

Ah - we can just write a "partition-done" file, or rename the partition directory to do this. So yeah, we can definitely do a reasonable job of checking in a reasonable time.

jeromekelleher added a commit to jeromekelleher/bio2zarr that referenced this issue Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants