-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrity tests needed for dencode #138
Comments
On this theme - currently if a partition is missing due to job failure, |
Should finalise try to check if everything is present first? This means looking at each array in each partition, so O(10000) directory check operations. This is probably simpler than trying to make finalise robust to making multiple passes, but is ultimately less robust I guess. |
Checking that each partition is present and that there are no |
Ok, let's try that in the first instance |
I'll code it up later |
Ah - we can just write a "partition-done" file, or rename the partition directory to do this. So yeah, we can definitely do a reasonable job of checking in a reasonable time. |
Closes sgkit-dev#138 Closes sgkit-dev#139
#136 added the distributed encode operation, but only with very basic tests to check things work in the nominal case.
Needs some tests to be sure we do the right thing when things go wrong.
The text was updated successfully, but these errors were encountered: