diff --git a/lib/run_part.c b/lib/run_part.c index 2514e15f3..b271f4ce8 100644 --- a/lib/run_part.c +++ b/lib/run_part.c @@ -15,43 +15,43 @@ #include "shadowlog_internal.h" -int run_part (char *script_path, const char *name, const char *action) +static int run_part(char *script_path, const char *name, const char *action) { - int pid; + pid_t pid; int wait_status; - int pid_status; + pid_t pid_status; char *args[] = { script_path, NULL }; pid=fork(); if (pid==-1) { - perror ("Could not fork"); + fprintf(shadow_logfd, "fork: %s\n", strerror(errno)); return 1; } if (pid==0) { - setenv ("ACTION",action,1); - setenv ("SUBJECT",name,1); - execv (script_path,args); - perror ("execv"); + setenv("ACTION",action,1); + setenv("SUBJECT",name,1); + execv(script_path,args); + fprintf(shadow_logfd, "execv: %s\n", strerror(errno)); exit(1); } - pid_status = wait (&wait_status); + pid_status = wait(&wait_status); if (pid_status == pid) { return (wait_status); } - perror ("waitpid"); + fprintf(shadow_logfd, "waitpid: %s\n", strerror(errno)); return (1); } -int run_parts (const char *directory, const char *name, const char *action) +int run_parts(const char *directory, const char *name, const char *action) { struct dirent **namelist; int scanlist; int n; int execute_result = 0; - scanlist = scandir (directory, &namelist, 0, alphasort); + scanlist = scandir(directory, &namelist, 0, alphasort); if (scanlist<=0) { return (0); } @@ -61,7 +61,7 @@ int run_parts (const char *directory, const char *name, const char *action) struct stat sb; if (asprintf(&s, "%s/%s", directory, namelist[n]->d_name) == -1) { - fprintf(stderr, "could not allocate memory\n"); + fprintf(shadow_logfd, "asprintf: %s\n", strerror(errno)); for (; nd_name); for (; n