Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cz-cardview element fixed to half the screen width, should be smaller for columns=1 #78

Open
alancutter opened this issue Oct 18, 2016 · 3 comments

Comments

@alancutter
Copy link
Collaborator

alancutter commented Oct 18, 2016

Attempted to fix this but ran into a Polymer bug where the <template is='dom-repeat' items={{views}}> doesn't update when views.length becomes 1 inside columnsChanged().

Next step is to try updating Polymer or create a work around.

@alancutter
Copy link
Collaborator Author

+@shans: Seems like views is already a property. For some reason this.set('views', views) on line 169 with an array of length 1 is not causing the template to remove the second .card-content element.

@shans
Copy link
Owner

shans commented Oct 19, 2016

You could try changing the type of views from 'Object' to 'Array' and see
if that helps?

On Wed, 19 Oct 2016 at 16:48 alancutter notifications@github.com wrote:

+@shans https://github.com/shans: Seems like views is already a
property. For some reason this.set('views', views) on line 169 with an
array of length 1 is not causing the template to remove the second
.card-content element.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#78 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAUFXW5QbtPAb4oWxvTw346NfpcMDS_Lks5q1a85gaJpZM4KZTvQ
.

@alancutter
Copy link
Collaborator Author

alancutter commented Oct 20, 2016

Good idea but unfortunately no, I still see the same DOM behaviour.
Up to date diff link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants