Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #597

Closed
wants to merge 2 commits into from
Closed

Upgrade dependencies #597

wants to merge 2 commits into from

Conversation

curran
Copy link
Contributor

@curran curran commented Mar 2, 2023

Closes #596

@curran
Copy link
Contributor Author

curran commented Mar 2, 2023 •
edited
Loading

Surprisingly, only one test fails!

  1) client connection
       still connects to legacy clients, whose ID changes on reconnection:

      Uncaught AssertionError: expected '50ad38fd7055c23a8c559a501b616e01' to not equal '50ad38fd7055c23a8c559a501b616e01'
      + expected - actual

@curran curran marked this pull request as draft March 2, 2023 09:02
curran
curran commented May 23, 2023
View reviewed changes
Copy link
Contributor Author

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to stay legacy

package.json Outdated Show resolved Hide resolved
alecgibson
alecgibson reviewed May 23, 2023
View reviewed changes
package.json Outdated
"rich-text": "^4.1.0",
"sharedb-legacy": "npm:sharedb@=1.1.0",
"sinon": "^7.5.0"
"sharedb-legacy": "npm:sharedb@=3.2.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't bump this. This was specifically pinned to an old version to test backwards compatibility. This is why your test is failing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

Fixed in #618

@curran
Copy link
Contributor Author

curran commented Aug 15, 2023

Closing in favor of #618

@curran curran closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecgibson alecgibson alecgibson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade dependencies
2 participants
@curran @alecgibson