added correct user to stop_sync drop of subscription (#183)

* added user to subscription drop

* added privilege tests

* updating tests to leverage no_sup user

Author: annadowling

lib/pg_easy_replicate/orchestrate.rb

@@ -167,6 +167,7 @@ def drop_subscription(group_name:, target_conn_string:)
         Query.run(
           query: "DROP SUBSCRIPTION IF EXISTS #{subscription_name(group_name)}",
           connection_url: target_conn_string,
+          user: db_user(target_conn_string),
           transaction: false,
         )
       rescue => e

spec/pg_easy_replicate/orchestrate_spec.rb

@@ -51,6 +51,27 @@
 
       expect(pg_publications(connection_url: connection_url)).to eq([])
     end
+
+    it "raises an error when user does not have sufficient privileges" do
+      # Use a limited user for this test case
+      restricted_user = "no_sup"
+      restricted_user_connection_url = connection_url(restricted_user)
+
+      described_class.create_publication(
+        group_name: "cluster1",
+        conn_string: connection_url,
+      )
+
+      expect do
+        described_class.drop_publication(
+          group_name: "cluster1",
+          conn_string: restricted_user_connection_url,
+        )
+      end.to raise_error(RuntimeError) { |e|
+        expect(e.message).to include("Unable to drop publication")
+      }
+      expect(pg_publications(connection_url: connection_url)).not_to eq([])
+    end
   end
 
   describe ".add_tables_to_publication" do
@@ -190,18 +211,9 @@
   describe ".drop_subscription" do
     before do
       PgEasyReplicate.bootstrap({ group_name: "cluster1" })
-
-      described_class.create_publication(
-        group_name: "cluster1",
-        conn_string: connection_url,
-      )
     end
 
     after do
-      described_class.drop_publication(
-        group_name: "cluster1",
-        conn_string: connection_url,
-      )
       PgEasyReplicate.cleanup({ everything: true, group_name: "cluster1" })
     end
 
@@ -218,6 +230,28 @@
 
       expect(pg_subscriptions(connection_url: target_connection_url)).to eq([])
     end
+
+    it "raises an error when user does not have sufficient privileges" do
+      # Use a limited user for this test case
+      restricted_user = "no_sup"
+      restricted_user_target_connection_url = target_connection_url(restricted_user)
+
+      described_class.create_subscription(
+        group_name: "cluster1",
+        source_conn_string: docker_compose_source_connection_url,
+        target_conn_string: target_connection_url,
+      )
+
+      expect do
+        described_class.drop_subscription(
+          group_name: "cluster1",
+          target_conn_string: restricted_user_target_connection_url,
+        )
+      end.to raise_error(RuntimeError) { |e|
+        expect(e.message).to include("Unable to drop subscription")
+      }
+      expect(pg_subscriptions(connection_url: target_connection_url)).not_to eq([])
+    end
   end
 
   describe ".start_sync" do