Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopping cart price rule does not allow single campaign eligibility constraint #22

Open
aboone opened this issue Jul 27, 2016 · 0 comments

Comments

@aboone
Copy link
Member

aboone commented Jul 27, 2016

The following code appears to prevent users from creating a shopping cart price rule with a single condition on "SheerID Campaign Eligibility" without also creating conditions for each affiliation type verifiable through that campaign:
https://github.com/sheerid/sheerid-magento/blob/2.1.2/app/code/SheerID/Verify/controllers/VerifyController.php#L30-L33

The current documentation appears to be incorrect/misleading with regards to this behavior:
https://github.com/sheerid/sheerid-magento/blob/2.1.2/docs/SheerID_Verify-UserGuide.md#condition-sheerid-campaign-eligibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant