-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profile2cami not working as expected #99
Comments
This tool was originally designed to convert profile tables with only leaf taxa. If your example, only
However, for the results of some classification tools, which do not always assign taxids as low as species rank, this tool can't handle them now. There's another script that could handle this, but it does not exist now ... |
OK, I'll improve it, tonight or tomorrow. |
Ideally I could support output from taxpasta, that would allow us to channel all profile outputs trough this tool for usage with OPAL. |
OK, it's fixed by adding a new flag.
Please try the binary and tell me if you have any further issues (I tested it, and it's compatible with previous behaviour). You example:
Another one I made:
|
Hi @shenwei356, thank you for the very quick fix, this works for our purpose, could you make a new release for this and update the bioconda recipe ? We would like to add the tool to Galaxy: galaxyproject/tools-iuc#6085 and therefore need the conda build. We would highly appreciate it, the addition to Galaxy will increase the visibility and usage of your tool. |
When using a profile with multiple ranks as input, the output gives summed up ranks for the higher ranks, e.g.:
Leads to:
That's not how the Cami Biobox is defined. https://github.com/CAMI-challenge/contest_information/blob/master/file_formats/CAMI_TP_specification.mkd states
The percentages given for all taxa from the same rank should sum up to <= 100%
.So the normalization should happen per rank in my understanding.
The text was updated successfully, but these errors were encountered: