"Generating key + certificate" message

[wlandau]

It's a small thing, but rnng_write_cert() prints "Generating key + certificate" messages when the R session is interactive. Example:

nanonext/src/tls.c

Line 158 in 63792bd

if (interactive) REprintf("Generating key + certificate [ ]");

I don't think the time delay (~1s) is burdensome enough to require a progress message, and I find messages from REprintf() difficult to suppress without also suppressing errors.

[shikokuchuo]

Sometimes it can take ~2 seconds and is noticeable. Without a prompt, the user won't know that it's doing what it's supposed to be doing rather than just being slow.

Why do you need to suppress it for interactive sessions? Would something else be more helpful?

[shikokuchuo]

Actually it's a good suggestion for nanonext and I'm merging a PR which removes it from here. However I will re-instate the user prompt at mirai unless you have a better suggestion. Thanks.

[wlandau]

Moving the message to mirai sounds great, especially if you plan on using message() so messages are easy to suppress (c.f. https://devguide.ropensci.org/pkg_building.html#console-messages). Like the dev guide says, it would also be great to turn off the message with a function argument.

[shikokuchuo]

Since when does my code adhere to any style guide? ;)