fix lints

Author: ashwiniag

internal/assigner/assigner.go

@@ -40,12 +40,10 @@ func StartAssigner(server string, port int, token string, interval time.Duration
 	ticker := time.NewTicker(interval)
 	defer ticker.Stop()
 
-	for {
-		select {
-		case <-ticker.C:
-			AssignTasks(server, port, token)
-		}
+	for range ticker.C {
+		AssignTasks(server, port, token)
 	}
+
 }
 
 func AssignTasks(server string, port int, token string) {
@@ -167,11 +165,7 @@ func isScanAssigned(server string, port int, token string, scanID uuid.UUID) boo
 	}
 	defer resp.Body.Close()
 
-	if resp.StatusCode == http.StatusOK {
-		return true
-	}
-
-	return false
+	return resp.StatusCode == http.StatusOK
 }
 
 func createAgentTask(server string, port int, token string, agentID int, scanID uuid.UUID) error {
@@ -206,31 +200,3 @@ func createAgentTask(server string, port int, token string, agentID int, scanID
 
 	return nil
 }
-
-//func updateAgentStatus(server, token string, agentID int, status string) error {
-//	reqBody := agents.UpdateAgentRequest{
-//		Status: &status,
-//	}
-//
-//	reqBodyJSON, _ := json.Marshal(reqBody)
-//
-//	req, err := http.NewRequest("PUT", fmt.Sprintf("%s/api/v1/agents/%d", server, agentID), bytes.NewBuffer(reqBodyJSON))
-//	if err != nil {
-//		return err
-//	}
-//
-//	req.Header.Set("Authorization", "Bearer "+token)
-//	req.Header.Set("Content-Type", "application/json")
-//
-//	resp, err := http.DefaultClient.Do(req)
-//	if err != nil {
-//		return err
-//	}
-//	defer resp.Body.Close()
-//
-//	if resp.StatusCode != http.StatusOK {
-//		return fmt.Errorf("server responded with status: %d", resp.StatusCode)
-//	}
-//
-//	return nil
-//}

internal/assigner/assigner_test.go

@@ -40,10 +40,16 @@ func TestAssignTasks(t *testing.T) {
 	scanHandler := func(w http.ResponseWriter, r *http.Request) {
 		if r.URL.Path == "/api/v1/scans" && r.URL.Query().Get("status") == "scan_pending" {
 			w.WriteHeader(http.StatusOK)
-			json.NewEncoder(w).Encode(mockScans)
+			if err := json.NewEncoder(w).Encode(mockScans); err != nil {
+				http.Error(w, "Failed to encode mock scans", http.StatusInternalServerError)
+				return
+			}
 		} else if r.URL.Path == "/api/v1/agents" && r.URL.Query().Get("status") == "connected" {
 			w.WriteHeader(http.StatusOK)
-			json.NewEncoder(w).Encode(mockAgents)
+			if err := json.NewEncoder(w).Encode(mockAgents); err != nil {
+				http.Error(w, "Failed to encode mock agents", http.StatusInternalServerError)
+				return
+			}
 		} else if r.URL.Path == "/api/v1/agents/tasks" {
 			w.WriteHeader(http.StatusOK)
 		} else {
@@ -68,7 +74,10 @@ func TestAssignTasksWithNoAgents(t *testing.T) {
 	scanHandler := func(w http.ResponseWriter, r *http.Request) {
 		if r.URL.Path == "/api/v1/scans" && r.URL.Query().Get("status") == "scan_pending" {
 			w.WriteHeader(http.StatusOK)
-			json.NewEncoder(w).Encode(mockScans)
+			if err := json.NewEncoder(w).Encode(mockScans); err != nil {
+				http.Error(w, "Failed to encode mock scans", http.StatusInternalServerError)
+				return
+			}
 		} else if r.URL.Path == "/api/v1/agents" {
 			w.WriteHeader(http.StatusOK)
 			json.NewEncoder(w).Encode([]MockAgent{}) // No agents available

internal/restapi/v1/agenttasks/get_test.go

@@ -173,7 +173,3 @@ func TestListAgentTasks_OrderedByCreatedAt(t *testing.T) {
 	assert.Equal(t, task1.ID, res[0].ID) // Oldest task first
 	assert.Equal(t, task2.ID, res[1].ID) // Newest task last
 }
-
-func uuidPtr(u uuid.UUID) *uuid.UUID {
-	return &u
-}