Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

[Refactor] Simplify searchShortLink function #866

Open
arberiii opened this issue Jun 16, 2020 · 3 comments
Open

[Refactor] Simplify searchShortLink function #866

arberiii opened this issue Jun 16, 2020 · 3 comments
Assignees
Labels
Go Issue requires to write code using Go language maintainability

Comments

@arberiii
Copy link
Member

What is frustrating you?
Function searchShortLink is hard to read, especially the for loop.

func (s Search) searchShortLink(query Query, orderBy order.Order, filter Filter) (Result, error) {

Your solution
Refactor this function appropriately.

@arberiii arberiii added maintainability Go Issue requires to write code using Go language labels Jun 16, 2020
@hemachandarv
Copy link

@arberiii Would this be a good first issue? I'd like to work on this, if it hasn't been done already.

@arberiii
Copy link
Member Author

Yes, you can work on this! Please let me know if you have any trouble with the setup or anything else.

@hemachandarv
Copy link

Cool, I'll start working!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Go Issue requires to write code using Go language maintainability
Projects
None yet
Development

No branches or pull requests

3 participants