Incorrect signature for logger call

[pmacdonald-falcons]

tk-maya/engine.py

Line 153 in 00fa021

logger.debug("Refreshing the engine, previous context: '%r'", prev_context)

The string expansion here can be read as an argument here if custom handlers are added to the core handler. Update (and check all other apps and engines) for logger calls where the string is concatenated with "," rather than using fstring or % formatting.

logger.debug("Refreshing the engine, previous context: '%r'", prev_context)
should be
logger.debug("Refreshing the engine, previous context: '%r'" % prev_context)

Also here :

tk-maya/engine.py

Line 177 in 00fa021

logger.debug("Extracted sgtk instance: '%r' from path: '%r'", tk, new_path)

[julien-lang]

Hi @pmacdonald-falcons, thanks for reporting this issue.

I am not sure I understand the problem. From what I know, the Toolkit logger uses the Python logging module. And, according to the documentation, the % string formatting is supported with the function *args parameters:

The msg is the message format string, and the args are the arguments which are merged into msg using the string formatting operator.

Although, I am not sure what you mean by custom handlers so I might be missing something here. Please let me know.