Skip to content

Commit e624b5d

Browse files
Merge pull request #1 from shree-vastava/fix/chart_description_label
The text for chart description label was missing in the chart.
2 parents 3622b80 + e073b22 commit e624b5d

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ android {
1818
minSdkVersion 24
1919
targetSdkVersion 30
2020
versionCode 1
21-
versionName "1.0"
21+
versionName "1.1.0"
2222

2323
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
2424
}

app/src/main/java/com/acous/airqualityindex/ui/ChartActivity.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import androidx.lifecycle.Observer
1111
import com.acous.airqualityindex.R
1212
import com.acous.airqualityindex.data.CityAqi
1313
import com.acous.airqualityindex.util.Status
14+
import com.github.mikephil.charting.components.Description
1415
import com.github.mikephil.charting.components.XAxis
1516
import com.github.mikephil.charting.data.Entry
1617
import com.github.mikephil.charting.data.LineData
@@ -123,6 +124,9 @@ class ChartActivity : AppCompatActivity() {
123124
chart_aqi.axisRight.isEnabled = false
124125
chart_aqi.xAxis.textSize = 8f
125126
chart_aqi.legend.isEnabled = false
127+
var desc = Description()
128+
desc.text = """${getString(R.string.chart_desc)} ${cityAqi.city}"""
129+
chart_aqi.description = desc
126130
chart_aqi.setTouchEnabled(true)
127131
chart_aqi.xAxis.position = (XAxis.XAxisPosition.BOTTOM)
128132
chart_aqi.setDrawGridBackground(false)

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
<string name="seconds_remaining">Seconds for next value</string>
77
<string name="interval_label">Refresh Seconds</string>
88
<string name="refresh">Refresh</string>
9+
<string name="chart_desc">Air quality index of </string>
910
<string name="next_interval">The interval will be applicable from next cycle</string>
1011

1112
<string-array name="seconds_interval">

0 commit comments

Comments
 (0)