issuesv2_test.go

package main

import (
	"context"
	"net/http"
	"net/http/httptest"
	"testing"

	"github.com/shurcooL/home/internal/exp/service/change"
	"github.com/shurcooL/home/internal/exp/spa"
	"golang.org/x/net/webdav"
)

// Test that visiting /issues/github.com/shurcooL/issuesapp/new without being logged in
// redirects to /login.
func TestNewIssueRedirectsLogin(t *testing.T) {
	mux := http.NewServeMux()

	users, _, err := newUsersService(webdav.NewMemFS())
	if err != nil {
		t.Fatal(err)
	}
	issues, err := newIssuesServiceV2(webdav.NewMemFS(), nil, nil, users, nil)
	if err != nil {
		t.Fatal(err)
	}
	app := spa.NewApp(nil, issues, zeroChangeCounter{}, nil, users, nil)
	initIssuesV2(mux, issues, &appHandler{app.IssuesApp}, users)

	req := httptest.NewRequest(http.MethodGet, "/issues/github.com/shurcooL/issuesapp/new", nil)
	rr := httptest.NewRecorder()
	mux.ServeHTTP(rr, req)
	resp := rr.Result()
	if got, want := resp.StatusCode, http.StatusSeeOther; got != want {
		t.Errorf("got status code %d %s, want %d %s", got, http.StatusText(got), want, http.StatusText(want))
	}
	if got, want := resp.Header.Get("Location"), "/login?return=%2Fissues%2Fgithub.com%2FshurcooL%2Fissuesapp%2Fnew"; got != want {
		t.Errorf("got Location header %q, want %q", got, want)
	}
}

// Test that visiting /issues/github.com/shurcooL/issuesapp/1822 gives
// a 404 Not Found error (rather than 500 or something else).
func TestIssueNotFound(t *testing.T) {
	mux := http.NewServeMux()

	users, _, err := newUsersService(webdav.NewMemFS())
	if err != nil {
		t.Fatal(err)
	}
	issues, err := newIssuesServiceV2(webdav.NewMemFS(), nil, nil, users, nil)
	if err != nil {
		t.Fatal(err)
	}
	app := spa.NewApp(nil, issues, zeroChangeCounter{}, nil, users, nil)
	initIssuesV2(mux, issues, &appHandler{app.IssuesApp}, users)

	req := httptest.NewRequest(http.MethodGet, "/issues/github.com/shurcooL/issuesapp/1822", nil)
	rr := httptest.NewRecorder()
	mux.ServeHTTP(rr, req)
	resp := rr.Result()
	if got, want := resp.StatusCode, http.StatusNotFound; got != want {
		t.Errorf("got status code %d %s, want %d %s", got, http.StatusText(got), want, http.StatusText(want))
	}
	if got, want := resp.Header.Get("Content-Type"), "text/plain; charset=utf-8"; got != want {
		t.Errorf("got Content-Type header %q, want %q", got, want)
	}
	if got, want := rr.Body.String(), "404 Not Found\n"; got != want {
		t.Errorf("got body %q, want %q", got, want)
	}
}

// zeroChangeCounter implements change.Service that always returns 0 change count.
type zeroChangeCounter struct{ change.Service }

func (zeroChangeCounter) Count(context.Context, string, change.ListOptions) (uint64, error) {
	return 0, nil
}