Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export TypeScript definitions #16

Open
bhoudu opened this issue Apr 26, 2021 · 3 comments
Open

Export TypeScript definitions #16

bhoudu opened this issue Apr 26, 2021 · 3 comments

Comments

@bhoudu
Copy link

bhoudu commented Apr 26, 2021

This is more of a feature request than a bug.
It would be great to support TypeScript and produce index.d.ts so importing and using this lib would be easier.

@glitchgirl
Copy link

Were you able to get it to work with typescript? I am currently getting an error that says "Property AwsSigV4DriverRemoteConnection does not exist on type 'typeof driver'"?

@bhoudu
Copy link
Author

bhoudu commented May 4, 2021

Basically you can do without the types, but would be better if it was included. I just ended up reading this short useful lib and import * as gremlin to fallback.

import * as gremlin from 'gremlin-aws-sigv4';
import RemoteConnection = gremlin.driver.RemoteConnection;
import DriverRemoteConnection = gremlin.driver.DriverRemoteConnection;
import AwsSigV4DriverRemoteConnection = gremlin.driver.AwsSigV4DriverRemoteConnection

This lib gremlin-aws-sigv4 exports all that is included in vanilla gremlin lib.

@glitchgirl
Copy link

Thank you that helped a lot. Now I am just working on getting my queries to play nicely with Neptune. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants