Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeSlider.Preview doesn't resize SVG element based on graph size #578

Open
pstanton opened this issue Jul 25, 2017 · 1 comment
Open

Comments

@pstanton
Copy link

pstanton commented Jul 25, 2017

while the micro-graph and frame do resize, the containing SVG element does not.

changing the in render code to the following resolves the issue:

		this.svg.enter()
			.append("svg")
			.classed("rickshaw_range_slider_preview", true)
			.style("position", "absolute")
			.style("top", 0);

		this.svg.style("height", this.config.height + "px")
			.style("width", this.config.width + "px");
@pstanton pstanton changed the title RangeSlider.Preview doesn't resize based on graph size RangeSlider.Preview doesn't resize SVG element based on graph size Jul 25, 2017
@pstanton
Copy link
Author

i created a patch, but i left a line in that is not correct
https://github.com/pstanton/rickshaw/commit/d3d3febb441d2846da4268c8f4db7e688b6b4b7c
how do i remove the line (last line in change which includes jquery code) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant