Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: allow using docker locally configured for DOCKER_HOST tcp/http values #1959

Open
1 task done
AndreiOrmanji opened this issue Jan 15, 2025 · 0 comments · May be fixed by #1960
Open
1 task done

[Improvement]: allow using docker locally configured for DOCKER_HOST tcp/http values #1959

AndreiOrmanji opened this issue Jan 15, 2025 · 0 comments · May be fixed by #1960
Labels
S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features

Comments

@AndreiOrmanji
Copy link

Describe the improvement

My local setup requires using DOCKER_HOST=tcp://localhost:2375. Such configuration can not be used with shuttle run command at least for versions 0.51.0, because it relies on connect_with_local_defaults method, that uses unix sockets for unix and named pipe for windows. bollard crate (starting from version 0.16.0) has connect_with_defaults method, that tries all possible variants of DOCKER_HOST value types (sockets, named pipes, http, https).

I suggest updating to the latest version of bollard crate

- bollard = "0.15.0"
+ bollard = { version = "0.18.1", features = ["ssl_providerless"] }

replace calls of connect_with_local_defaults to connect_with_defaults to fix cases when DOCKER_HOST is set up as tcp/http/https
replace calls of connect_with_unix to connect_with_socket, because it was renamed

Duplicate declaration

  • I have searched the issues and this improvement has not been requested before.
@AndreiOrmanji AndreiOrmanji added S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features labels Jan 15, 2025
@AndreiOrmanji AndreiOrmanji linked a pull request Jan 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant