Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple issues around compiling with msbuild instead of ninja #65

Closed
fmoessbauer opened this issue Jun 15, 2020 · 3 comments
Closed

Multiple issues around compiling with msbuild instead of ninja #65

fmoessbauer opened this issue Jun 15, 2020 · 3 comments
Assignees
Labels
bug Something isn't working prio:low

Comments

@fmoessbauer
Copy link
Member

When msbuild is used as generator, we run into the following issues:

  • build type is not available at configure time => use generator expressions
  • TSAN dll is not copied to output directory
  • Only non-debug builds work, probably due to missing build type

note: This only affects compiling the sources. A workaround is to use the ninja generator.

@fmoessbauer fmoessbauer self-assigned this Jun 15, 2020
@fmoessbauer fmoessbauer added bug Something isn't working prio:low labels Jun 15, 2020
@fmoessbauer
Copy link
Member Author

Actually the build type was not used during configure time in DRace, but unfortunately DynamoRIO does. See #53 for details. By that, the build type at configure time (which is defaulted to release in DynamoRIO + client) does not match the default build type debug at compile time.

I now added an assertion notifying that you have to specify the build type at configure time when using MSBuild generator. The other issue with the missing TSAN dll is fixed now.

@ddiefenthaler, could you please check if the patch works for you (branch: chore/msbuild)

@fmoessbauer
Copy link
Member Author

Fixed in 0e8ecb5

@ddiefenthaler
Copy link

I have tried the new branch,
and while the configure now correctly works, it fails during the build time.

The issue seems to be the copy of the tsan-dll,
as this fails to create the directory when the build isn't a debug build.

I pushed a fix to the branch chore/msbuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio:low
Projects
None yet
Development

No branches or pull requests

2 participants