fix(docs/refactor-examples): enhance chart documentation #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 45b7692 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Report of
|
matthiashader
added
Deploy Preview
✅ Deploy Preview for industrial-experience ready!
|
matthiashader
added
Deploy Preview
danielleroux
requested changes
Aug 19, 2024
packages/angular-test-app/src/preview-examples/echarts-bar-horizontal-stacked.html
Outdated
Show resolved
Hide resolved
packages/angular-test-app/src/preview-examples/echarts-empty-state.html
Outdated
Show resolved
Hide resolved
packages/angular-test-app/src/preview-examples/echarts-empty-state.ts
Outdated
Show resolved
Hide resolved
packages/angular-test-app/src/preview-examples/echarts-line-multiple-y-axis.ts
Outdated
Show resolved
Hide resolved
danielleroux
requested changes
Aug 22, 2024
packages/angular-test-app/src/preview-examples/echarts-bar-horizontal-stacked.ts
Outdated
Show resolved
Hide resolved
…rt-types # Conflicts: # packages/angular-test-app/src/app/app-routing.module.ts # packages/angular-test-app/src/app/app.module.ts # packages/html-test-app/src/preview-examples/echarts.html # packages/react-test-app/src/main.tsx # packages/vue-test-app/src/Root.vue # pnpm-lock.yaml
danielleroux
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 What is the current behavior?
Currently only one preview example exists for the charting topic, which is not suifficient and doesn't show the capabilities.
GitHub Issue Number: #N/A, IX-1551
🆕 What is the new behavior?
To show the capabilities of charting with Apache ECharts and the corresponding iX theme, new preview examples for all frameworks have been created.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs)pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support