Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown positioning #1681

Merged
merged 15 commits into from
Feb 12, 2025
Merged

fix: dropdown positioning #1681

merged 15 commits into from
Feb 12, 2025

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Feb 7, 2025

💡 What is the current behavior?

GitHub Issue Number: Closes #1348, [IX-1449]

  • dropdown positioning breaks inside floating-ui (dialog)

🆕 What is the new behavior?

  • dropdowns are now correctly positioned inside floating-ui elements

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

@jul-lam jul-lam self-assigned this Feb 7, 2025
Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 7eb4def

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jul-lam jul-lam marked this pull request as ready for review February 11, 2025 10:12
Copy link
Collaborator

@AndreasBerliner AndreasBerliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR does not introduce a fix, but includes refactorings and tests the behavior.
Update: The fix seems to be introduced by the dependency update of 'floating-ui'.

.changeset/heavy-cups-peel.md Outdated Show resolved Hide resolved
@jul-lam jul-lam requested a review from danielleroux February 12, 2025 14:01
@danielleroux danielleroux merged commit 5b56d90 into main Feb 12, 2025
15 checks passed
@danielleroux danielleroux deleted the fix/dropdown-position branch February 12, 2025 14:09
@github-actions github-actions bot mentioned this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animating transition in container, breaks select position calculation.
3 participants