Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write struct by Children containing Array #8

Open
KircMax opened this issue Nov 10, 2021 · 1 comment
Open

Write struct by Children containing Array #8

KircMax opened this issue Nov 10, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@KircMax
Copy link
Collaborator

KircMax commented Nov 10, 2021

Prior to implementing support for arrays in structs the following feature must be implemented:
#1
afterwards the Extension PlcProgramReadStructByChildValues/ ApiPlcProgramHandler shall be checked to support writing by writing children also for the arrays

@KircMax KircMax added the enhancement New feature or request label Nov 14, 2021
@KircMax
Copy link
Collaborator Author

KircMax commented Nov 26, 2021

just a thought:
maybe refactor current read to:
call a new function that will recursively call itself until the plcprogramdata is readable => then return the ApiRequest
==> RecursiveBuildBulkRequest
=> Use the built Bulk Request to read the child values and apply the values of the children accordingly (might need a findChildByPath(string childPath) or something like that)
benefit:
single bulk request (more performant)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant