Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow referencing version in wakeLanguageServer.path #1673

Open
ag-eitilt opened this issue Jan 15, 2025 · 0 comments
Open

Allow referencing version in wakeLanguageServer.path #1673

ag-eitilt opened this issue Jan 15, 2025 · 0 comments
Labels
enhancement New feature or request extension & LSP good first issue Good for newcomers

Comments

@ag-eitilt
Copy link
Collaborator

With the extension now referencing an external installation, it can (usually) be easily pointed to the latest/current version on the machine as a proxy for "most likely to be the relevant version". However, since we track which exact version should be used in .wakeroot, we could theoretically be more specific on systems which additionally keep old/experimental versions alongside that, and have the extension automatically switch the version used based on the workspace it's operating in, without needing to manually set workspace-specific settings (which don't work for all workflows anyway).

We might not want to expose the user's full environment to the LSP, but processing a restricted set of %v replacements (something like /usr/share/wake/%v/bin/wake) seems like it could be nice for not only the wakeLanguageServer.path listed in the title, but also the wakeLanguageServer.standardLibrary to support all potential installation arrangements.

The issue label is a bit misleading: this is probably not a good first issue for someone just familiarizing themself with the codebase, but is likely a good second issue.

@ag-eitilt ag-eitilt added enhancement New feature or request extension & LSP good first issue Good for newcomers labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extension & LSP good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant