Unresponsive Remove/Block New Chat Options

[Sagar0-0]

Guidelines

• I have searched searched open and closed issues for duplicates
• I am submitting a bug report for existing functionality that does not work as intended
• This isn't a feature request or a discussion topic

Bug description

Steps:

1. Go to the New Message Screen by clicking on the FAB
2. Long press on any contact.
3. Choose the option to Remove or Block the a Recipient.
4. A Snackbar pops up immediately, but the Recipient is removed later after the refresh call is completed executing.

Problem:
This gives the user a sense of unresponsiveness if the apps shows the snack bar saying "%s HAS BEEN REMOVED!", but does not remove the list item at the same time.

Solutions:

1. Change the Snackbar to show the message as "Removing...".
2. The onRefresh call is triggered, we can show the SwipeRefresh indicator as well.
3. We have to remove the Recipient from the pagedData (responsible for the recipient's list) immediately when the Remove/Block call is triggered and call the required hide/block functions in the background without calling the onRefresh(). This way the response will be immediate to the user and the SignalDatabase.recipients will be also updated leading to the updated list on the next refresh/fetch call. (This may need some refactoring as the pagedData can be only updated with a pagedDataSource) (This might be a time-consuming change and the improvement/effect is not huge, hence not recommended).

I have made the changes for Option 2, and ready with a PR.

Screenshots

document_6319097752387064452.mp4

Device

Realme GT NEO 3T

Android version

14

Signal version

7.28.4

Link to debug log

NA

[greyson-signal]

(2) sounds good to me, thank you!

[Sagar0-0]

@greyson-signal I am starting with testing the app, reporting whatever issues I find, and fixing them with PRs, making myself comfortable with the codebase (Would love to contribute to major features in the future).
I hope this won't feel like spamming with issues and PRs.