Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update (old-uninstaller.exe) crash on Windows #7053

Open
2 tasks done
daniel-ayers opened this issue Oct 17, 2024 · 10 comments
Open
2 tasks done

Auto update (old-uninstaller.exe) crash on Windows #7053

daniel-ayers opened this issue Oct 17, 2024 · 10 comments
Labels

Comments

@daniel-ayers
Copy link

daniel-ayers commented Oct 17, 2024

Using a supported version?

  • I have searched searched open and closed issues for duplicates.
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

While apparently attempting an automatic update, Signal Desktop (Windows 11) crashed resulting in the app no longer being installed (however a non-functional Start Menu entry was left behind).

Windows event log shows five crashes of old-uninstaller.exe (version 7.28.0.0) about 2-3 seconds apart.

Faulting application name: old-uninstaller.exe, version: 7.28.0.0, time stamp: 0x5c157f86
Faulting module name: ntdll.dll, version: 10.0.26100.2033, time stamp: 0xc415c4aa
Exception code: 0xc0000374
Fault offset: 0x000f9c3f
Faulting process id: 0x3558
Faulting application start time: 0x1DB1FFAF285BC87
Faulting application path: C:\Users\<USERNAME>\AppData\Local\Temp\nsq133.tmp\old-uninstaller.exe
Faulting module path: C:\WINDOWS\SYSTEM32\ntdll.dll
Report Id: 76758f52-0461-42de-b247-50621d80546e
Faulting package full name: 
Faulting package-relative application ID: 

Exception code and fault offset are the same for all five crashes.

OS Details:

Edition Windows 11 Enterprise
Version 24H2
Installed on ‎16/‎10/‎2024
OS build 26100.2033
Experience Windows Feature Experience Pack 1000.26100.23.0

Steps to reproduce

  1. Do nothing, the problem happens in the background.
  2. Come to your computer and notice that there is an error dialog.
  3. Note that Signal is no longer installed.

Expected result

App is updated in background.

Actual result

Update process crashes. App is no longer installed (except for non-functional Start Menu entry left behind).

Screenshots

No response

Signal version

7.28.0

Operating system

Windows 11 24H2 26100.2033

Version of Signal on your phone

7.32 (384)

Link to debug log

No response

Note: Edited by OP to fix typo: "aout" -> "about".

@daniel-ayers
Copy link
Author

For the benefit of any others who experience this type of problem, the orphaned Start Menu item can be removed using this procedure:

Can you if it is still visible in the apps folder? Press Win + R then enter Shell:AppsFolder

If it is, right-click on it then select uninstall. If you see that it is a blank icon, right-click on it then select Open file location and then delete it from the folder.

Credit: Paulo GM on Microsoft Answers

@jernej-9
Copy link

jernej-9 commented Nov 1, 2024

I've been experiencing the same type of problem (Windows 11 as well). Without any user input, Signal completely bricks itself. According to the Signal logs, this happens during an auto update in the background, leaving only broken desktop and start menu shortcuts behind. The Signal installation directory the shortcuts point to is completely empty. The only way that I've found to restore it is to download the installer and go through the installation again.

@scottnonnenberg-signal
Copy link
Contributor

@jernej-9 I'm sorry that's happening to you. Do you see the same historical crashes in the windows event log that Daniel does?

@daniel-ayers
Copy link
Author

Update - since opening this issue there have been (at least) two further updates to Signal Desktop on my machine which fail with an error dialog appearing. I figured they are the same issue so did not make duplicate reports.

@daniel-ayers
Copy link
Author

I suspect this may have something to do with Windows security features, so to clarify on my machine:

  • Memory integrity is ON
  • LSA protection is ON
  • Defender credential guard is ON
  • Vulnerable driver blocklist is ON
  • MS Defender Smartscreen (check apps and files) is ON
  • Potentially unwanted app blocking is ON
  • All of the exploit protections (CFG, DEP, etc) are ON

@scottnonnenberg-signal
Copy link
Contributor

@daniel-ayers Thanks for that additional information - we'll take a look!

@daniel-ayers
Copy link
Author

I continue to have crashes during Signal updates, but I see that the crash is now happening in a different executable.

Faulting application name: signal-desktop-win-7.32.0.exe, version: 7.32.0.0, time stamp: 0x5c157f86
Faulting module name: ntdll.dll, version: 10.0.26100.2033, time stamp: 0xc415c4aa
Exception code: 0xc0000374
Fault offset: 0x000f9c3f
Faulting process id: 0x36F4
Faulting application start time: 0x1DB30A722810CEB
Faulting application path: C:\Users\<Username>\AppData\Roaming\Signal\update-cache\signal-desktop-win-7.32.0.exe
Faulting module path: C:\WINDOWS\SYSTEM32\ntdll.dll
Report Id: 1803b402-c18e-4772-a68c-0456f85a8b90
Faulting package full name: 
Faulting package-relative application ID: 

The following error dialog appears:

Screenshot 2024-11-07 132222

@scottnonnenberg-signal
Copy link
Contributor

@daniel-ayers Does your system perhaps have locks on the old Signal Desktop files? https://superuser.com/questions/117902/find-out-which-process-is-locking-a-file-or-folder-in-windows

@daniel-ayers
Copy link
Author

I ran this from an Administrator CMD.EXE ...

openfiles /query /fo table > c:\temp\openfiles.txt

... three times.

First, before opening Signal (it is configured to close rather than background itself). It was in the state where the auto-update failed. When I opened Signal it told me there was an update to apply.

Second, before manually applying the update by clicking on the blue button with the circular arrow.

Third, after the update had completed.

The output was the same on all three occasions:

INFO: No shared open files found.


Files opened remotely via local share points:
---------------------------------------------

INFO: No shared open files found.

Was that the test you were thinking of?

I will try adding AV exclusions just in case AV is getting in the way. If new EXEs/DLLs are being extracted, written and executed that could be something that AV is poking its nose into.

I take it the crash implies a failure to delete or get an exclusive write lock on something?

@indutny-signal
Copy link
Contributor

To be honest, I'm not entirely sure why it is crashing. Typically errors during uninstall don't result in crashes and are bubbled up to the user via UI gracefully. In this case, however, it appears to be a hard crash...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants