Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barely visible tray icon in 7.33 #7082

Open
2 tasks done
ygoe opened this issue Nov 13, 2024 · 33 comments
Open
2 tasks done

Barely visible tray icon in 7.33 #7082

ygoe opened this issue Nov 13, 2024 · 33 comments

Comments

@ygoe
Copy link

ygoe commented Nov 13, 2024

Using a supported version?

  • I have searched searched open and closed issues for duplicates.
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

The tray icon (shell notification icon in the taskbar) used to be the mid-blue shape with the white bubble outline shape. Now it's just a dark-blue shape that is barely visible on a dark taskbar.

Steps to reproduce

Nothing, just start the app (maybe enable the tray icon, not sure, it's just there)

Expected result

I found this older screenshot from 2023-11-29:
grafik

A clearly visible and recognisable tray icon

Actual result

grafik

That dark blue spot between the expander arrow and the green KeePassXC icon.

Screenshots

No response

Signal version

7.33.0

Operating system

Windows 11

Version of Signal on your phone

No response

Link to debug log

No response

@demux4555
Copy link

Confirming that I have the same issue here on Windows 10

@trevorleenc
Copy link

Just updated on Ubuntu 22.04.5 and have found the same thing.

@corobin
Copy link

corobin commented Nov 13, 2024

i came to report the same problem. it is hardly visible

the previous icon was already pretty bad compared to the even earlier one, and now they just made it even worse

@ppoutine
Copy link

Just wait until you have an unread message. The problem gets even worse with an unread badge on top.
signal1

@arnowelzel
Copy link

Same here - on a 4K display you can see that the icon is low resolution as well:

image

@SilenyKrecek
Copy link

+1, give us the old icon back, or better, add an option to choose from several scalable variants, e.g., white monochrome for a system-like window look on a dark toolbar.

@janci007
Copy link

janci007 commented Nov 14, 2024

Windows 11, after updating to Signal 7.33 the icon changed to a different one with low resolution
(4K display, 150% dpi scaling in display settings)
Screenshot 2024-11-14 124321
Screenshot 2024-11-14 124336

@itkfm
Copy link

itkfm commented Nov 14, 2024

7.33 on Linux still uses the low-contrast one:
image

@itkfm itkfm mentioned this issue Nov 14, 2024
2 tasks
@trevor-signal
Copy link
Contributor

Thanks all for these reports; we'll check with our design team.

@oomek
Copy link

oomek commented Nov 14, 2024

The new icon is just dreadful! Can't look at it without feeling an intense disgust. Please bring the old one back.
Alternatively make something better without dashed lines and something that works in light and dark theme and in small sizes in the system tray.

@corobin
Copy link

corobin commented Nov 14, 2024

@ppoutine

Just wait until you have an unread message. The problem gets even worse with an unread badge on top.

you weren't kidding. and it's way worse than it looks in the screenshot

@SilenyKrecek

+1, give us the old icon back, or better, add an option to choose from several scalable variants, e.g., white monochrome for a system-like window look on a dark toolbar.

an option would be good, not everyone would necessarily want the monochrome icon. e.g. on my system tray it would blend in with all the other monochrome icons and be harder to distinguish, i would like the chat app to be distinct

@oomek
Copy link

oomek commented Nov 14, 2024

At first I thought my system tray has glitched. Then I've realised it's "upgraded" Signal icon 🤣

@jamiebuilds-signal
Copy link
Member

For Windows users having trouble with the tray icon having low contrast (blue on black, or white on white):

The issue appears to be the split "custom" theme on windows:

signal-2024-11-14-122030_002

  • "Windows mode" = "Dark" and "app mode" = "Light" → Dark Tray with Blue Icon
  • "Windows mode" = "Light" and "app mode" = "Dark" → Light Tray with White Icon

Looking at fixing this issue, but in the interim if you make your "Windows mode" and "app mode" both "Light" or both "Dark" it should look a bit better.

As for Linux users, the issue may be similar with us getting a mismatching theme setting from your tray. Any details you can provide will help

@oomek
Copy link

oomek commented Nov 14, 2024

It's not about colour. The new icon is just ugly.

@arnowelzel
Copy link

arnowelzel commented Nov 15, 2024

I agree to @oomek - the old icon was much better and is also still used as app icon (at least in Windows). So why not just keeping the app icon as TrayIcon as well? It is easy to recognize and looks better:

image

image

And it should also not just be 16x16 pixels, since this really looks bad on HighDPI devices scaling.

@wooque
Copy link

wooque commented Nov 15, 2024

@jamiebuilds-signal

As for Linux users, the issue may be similar with us getting a mismatching theme setting from your tray. Any details you can provide will help

Add option in Preferences -> Appearance, like "Tray Theme" beside "Theme" so we can toggle preferred theme.

@gab81
Copy link

gab81 commented Nov 15, 2024

Yeah, just to add to the feedback, it's even more confusing if you use loom (million users), they look almost the same now:

image

Please put the old one back, it was just perfect, no need to change. Thank you.

@AndyFx12
Copy link

AndyFx12 commented Nov 15, 2024

grafik
It's on standard theme Linux Mint 22 (Mint-Y-Dark-Aqua) - and really hard to see. Please give us old or switchable icon back!

BTW: New App-icon (slightly darker blue) looks good.

@rsheftel
Copy link

Was this actually intentional? I assumed it was a mistake. Please revert.

@oomek
Copy link

oomek commented Nov 15, 2024

A little word of advise for the Signal logo designer. Dashed lines are very tricky to make right at such small sizes.
When you design a logo for Windows system tray make sure you design all the elements aligned to 16x16 grid, so when the system downscales it it's still crisp, or if you downscale it yourself. The default for the taskbar is 24x24, not a multiply of the base, but since it's a larger size so it's more forgiving.

@AndyFx12
Copy link

If I change my theme-settings to force dark mode, tray-icon changes to white color. It's even more ugly due to scaling (unsharp).
grafik

@ppoutine
Copy link

The issue appears to be the split "custom" theme on windows:

First I can confirm the @jamiebuilds-signal diagnosis - the tray icon is basing its colour on the “default app mode” while the taskbar colour comes from the ”default Windows mode”, so if a user has those two colours set different they'll get a mismatched tray icon colour.

Second, and separately, even with the right colour it still feels like this new tray icon is too obscured by the unread badge

@jamiebuilds-signal
Copy link
Member

There appears to be enough issues trying to support themed tray icons on Windows and certain distributions of Linux that we've decided to replace the icon with a new version that should work better regardless of the selected theme. We should have a new version of the app out sometime early next week

@bk138
Copy link

bk138 commented Nov 16, 2024

There appears to be enough issues trying to support themed tray icons on Windows and certain distributions of Linux that we've decided to replace the icon with a new version that should work better regardless of the selected theme. We should have a new version of the app out sometime early next week

Just my 2 c: I think the old icon worked just well, at least on Linux GNOME and MacOS 😉.

@AndyFx12
Copy link

Just my 2 c: I think the old icon worked just well, at least on Linux GNOME and MacOS 😉.

... and Windows 10, 11 and Linux Mint ;-)

@Warwolt
Copy link

Warwolt commented Nov 16, 2024

Yeah, I also would very much appreciate just going back to the old icon. I'm not at all a fan of the dark blue color

@DimitriDR
Copy link

I just hate the new blue shade. Just look how It ruined my Dock harmony:

image

Like why? Same on my iPhone. Just give us the choice, many apps offer this (Reddit, Carrot to just name a few).

@FiSHYsolutions
Copy link

+1 using xubuntu 22.04 LTS

bash$ grep png $(find /snap/signal-desktop/current/ -name "*.desktop")
Icon=${SNAP}/meta/gui/signal-desktop.png

is this png used somewhere or does it just waste diskspace?

signal-desktop

@Fuchs
Copy link

Fuchs commented Nov 16, 2024

Please just give us an option for it to be monochrome and, also on Linux, if it's supposed to be dark (for light themes) or bright (for dark themes).
If your design team disagrees, please just give us and icon themes the option to override it by loading a specific file if present. Thanks.

@bouras
Copy link

bouras commented Nov 16, 2024

another vote for bringing back the old icon

@zakutin
Copy link

zakutin commented Nov 16, 2024

image

Linux/GNOME, it looks odd...

@Septicity
Copy link

"Symbolic icons" as a whole were designed for this exact purpose. Completely hard-coded solid-color icons on a system tray have consistently been criticized and suggested against; mostly for specifically white or black icons, but it applies to this as well. At the very least, is there a particular icon name it expects from the icon theme to change this ourselves (e.g. "signal-applet.png" or "signal-applet.svg")?

@ygoe
Copy link
Author

ygoe commented Nov 17, 2024

Now at night with my blue light filter active, that dark blue blob is almost black, and hardly visible at all on the very dark taskbar. But I guess this is mostly a bug related to the wrong theme icon being selected.

Anyway, what I mean to say is that new dark blue is next to black with a blue light filter. It's just a bad signal colour (no pun intended) to use in a GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests