Critical regression in 7.46.0: turning on screen-sharing instead turns on video camera

[raxod502]

Using a supported version?

• I have searched searched open and closed issues for duplicates.
• I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

In version 7.46.0 there is a major regression from 7.45.1 which affects screen-sharing. When enabling screen-sharing, Signal instead turns on the system camera feed without informing the user, and sends it to the rest of the call. If video permissions have not been granted when clicking the "share screen" button, Signal requests them before proceeding.

This has also been mentioned in an old issue #6994 (comment), but I am opening a new issue because the behavior of Signal silently turning on the user's camera feed without informing them seems very concerning and needs visibility for other impacted users visiting the bug tracker.

We tested and verified that the issue reproduces with the official Signal desktop client 7.46.0 on both Linux and macOS, and is resolved by downgrading to 7.45.1.

Steps to reproduce

1. Start or join a group call
2. Click the "share screen" button

Expected result

Signal should share a feed of the device screen

Actual result

Signal shares the device camera feed

Screenshots

No response

Signal version

7.46.0

Operating system

Pop!_OS 22.04

Version of Signal on your phone

7.31.1

Link to debug log

I see one was already shared by another impacted user in #6994 (comment), but please let me know if you would like me to provide a log as well.

[raxod502]

This commit looks potentially related: 0c875b4

Specifically I see some changes to add await ensureSystemPermissions({ hasLocalAudio, hasLocalVideo }) calls, which would explain the behavior reported in #6994 (comment); I also see a number of changes to the control flow of calls to setOutgoingVideo, including one that has an argument of this.#hadLocalVideoBeforePresenting ?? hasLocalVideo, which seems very relevant (the value of hadLocalVideoBeforePresenting being ignored might lead to Signal forgetting that you did not have your camera enabled before you tried to enable screen-sharing, which is the observed behavior).

[gkarthikreddi]

Facing the same issue on Mac, when trying to present, I'm getting a banner saying "Click here to stop presenting" but it's not presenting anything.

[01111010t]

Same issue on Fedora 41 & Signal 7.46.0

[ayumi-signal]

We can confirm and are working on a fix.

[ayumi-signal]

We've released 7.46.1 and 7.47.0-beta.2 to fix this issue. Sorry about that! please upgrade when you can.
https://github.com/signalapp/Signal-Desktop/releases/tag/v7.46.1
https://github.com/signalapp/Signal-Desktop/releases/tag/v7.47.0-beta.2

[01111010t]

We've released 7.46.1 and 7.47.0-beta.2 to fix this issue. Sorry about that! please upgrade when you can. https://github.com/signalapp/Signal-Desktop/releases/tag/v7.46.1 https://github.com/signalapp/Signal-Desktop/releases/tag/v7.47.0-beta.2

working as expected again on fedora 41 and signal 7.46.1