Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify mobile rum disk caching configuration #264

Open
mhennoch opened this issue Oct 6, 2023 · 2 comments
Open

Unify mobile rum disk caching configuration #264

mhennoch opened this issue Oct 6, 2023 · 2 comments

Comments

@mhennoch
Copy link
Contributor

mhennoch commented Oct 6, 2023

Currently:

Android
enableDiskBuffering
limitDiskUsageMegabytes

iOS
enableDiskCache
spanDiskCacheMaxSize

Android limit is set in MB and iOS one in bytes.
Default limit for both seems to be 25mb so that is fine.
Lets unify the configuration options? React Native and flutter will need those also.
@pellared
Copy link
Contributor

pellared commented Oct 9, 2023

Should it not be defined under https://github.com/signalfx/gdi-specification/blob/main/specification/configuration.md#real-user-monitoring-libraries?

@m-tu
Copy link

m-tu commented Oct 9, 2023

I would agree. I will have do come up with config options for RN soon will propose something then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pellared @m-tu @mhennoch