Merge pull request #11 from significa/delete-all-volumes

Add DELETE_ALL_VOLUMES to trigger backup

Author: guilherme1805

.github/workflows/trigger-backup.yaml

@@ -31,7 +31,21 @@ on:
         description: >-
           Makes the action crash if when the backup finishes there are still volumes in the app.
         required: false
+        default: true
         type: boolean
+      delete-al-volumes:
+        description: >-
+          Deletes all volumes in the backup worker after the backup has completed.
+        required: false
+        default: true
+        type: boolean
+      action-ref:
+        description: >-
+          The `ref` to clone the trigger backup script from. Allows to override GitHub's context
+          `github.action_ref` when it does not behave properly.
+        required: false
+        default: ${{ github.action_ref }}
+        type: string
 
     secrets:
       FLY_API_TOKEN:
@@ -48,6 +62,7 @@ jobs:
         with:
           repository: significa/fly-pg-dump-to-s3
           path: ./fly-pg-dump-to-s3
+          ref: ${{ inputs.action-ref }}
 
       - uses: superfly/flyctl-actions/setup-flyctl@master
 
@@ -61,3 +76,4 @@ jobs:
           FLY_VOLUME_SIZE: ${{ inputs.volume-size }}
           DOCKER_IMAGE: ${{ inputs.docker-image }}
           ERROR_ON_DANGLING_VOLUMES: ${{ inputs.error-on-dangling-volumes }}
+          DELETE_ALL_VOLUMES: ${{ inputs.delete-al-volumes }}

README.md

@@ -89,6 +89,10 @@ requirements in a simple way.
    - `ERROR_ON_DANGLING_VOLUMES`: After the backup completes, checks if there are any volumes still
      available, and crashes if so. This might be useful to alert that there are dangling volumes
      (that you might want to be paying for). Defaults to `true`.
+   - `DELETE_ALL_VOLUMES`: True to delete all volumes in the backup worker instead of the one used
+      in the machine. Fly has been very inconsistent with what volume does the machine start.
+      This solves the problem but prevents having multiple backup workers running in the same app.
+      Default to `true`.
 
    OPTION B: Call the reusable GitHub Actions workflow found in
    `.github/workflows/trigger-backup.yaml`. Example workflow definition:

trigger-backup.sh

@@ -11,13 +11,14 @@ FLY_MACHINE_SIZE=${FLY_MACHINE_SIZE:-shared-cpu-4x}
 FLY_VOLUME_SIZE=${FLY_VOLUME_SIZE:-3}
 DEFAULT_DOCKER_IMAGE="ghcr.io/significa/fly-pg-dump-to-s3:3"
 DOCKER_IMAGE=${DOCKER_IMAGE:-$DEFAULT_DOCKER_IMAGE}
-ERROR_ON_DANGLING_VOLUMES=${ERROR_ON_DANGLING_VOLUMES-true}
+ERROR_ON_DANGLING_VOLUMES=${ERROR_ON_DANGLING_VOLUMES:-true}
+DELETE_ALL_VOLUMES=${DELETE_ALL_VOLUMES:-true}
 VOLUME_NAME=${VOLUME_NAME:-temp_data}
 MAX_RETRIES=6
 
 # Fly has been proucing very inconsistent results, where the state is not propagated.
 # TODO: Sleeping between operations is not ideal.
-SLEEP_TIME_SECONDS=${SLEEP_TIME_SECONDS:-10}
+SLEEP_TIME_SECONDS=${SLEEP_TIME_SECONDS:-15}
 
 if [[ -z "$FLY_APP" || -z "$FLY_API_TOKEN" ]]; then
   >&2 echo "Env vars FLY_APP and FLY_API_TOKEN must not be empty"
@@ -61,14 +62,23 @@ sleep "$SLEEP_TIME_SECONDS"
 
 volume_id=vol_nylzrem87pd4qmk
 
-echo "Deleting volume '$volume_id'"
+delete_volume_or_volumes () {
+  if "$DELETE_ALL_VOLUMES" ; then
+    echo "Deleting all volumes in app '$FLY_APP'"
+    flyctl volumes list --json -a "$FLY_APP" | jq -r '.[].id' |  xargs -n1 flyctl volumes delete --yes
+  else
+    echo "Deleting volume '$volume_id'"
+    flyctl volumes delete --yes "$volume_id"
+  fi
+}
+
 attempt_num=0
 set +e
-while ! flyctl volumes delete --yes "$volume_id"; do
+while ! delete_volume_or_volumes; do
   attempt_num=$(( attempt_num + 1 ))
 
   if [ $attempt_num -ge $MAX_RETRIES ]; then
-    echo "Exceeded max retries ($MAX_RETRIES) deleting volume '$volume_id', exiting"
+    echo "Exceeded max retries ($MAX_RETRIES) deleting volume(s), exiting"
     exit 1
   fi