Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downscore per invalid response chunk in single lookup? #5603

Open
realbigsean opened this issue Apr 18, 2024 · 0 comments
Open

Downscore per invalid response chunk in single lookup? #5603

realbigsean opened this issue Apr 18, 2024 · 0 comments

Comments

@realbigsean
Copy link
Member

Description

From @dapplion in #5583

// TODO: We could NOT drop the request here, and penalize the peer again if
// sends multiple penalizable chunks after the first invalid.

If we get an error validating a response in on_single_block_response, currently we drop the request and downscore once, but we could be in the middles of downloading a stream of responses. We wouldn't downscore subsequent invalid responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant