Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate enable_light_client_server #6959

Open
michaelsproul opened this issue Feb 10, 2025 · 0 comments
Open

De-duplicate enable_light_client_server #6959

michaelsproul opened this issue Feb 10, 2025 · 0 comments

Comments

@michaelsproul
Copy link
Member

The enable_light_client_server config is parsed 3 separate times at startup, and shimmed into 3 different structs. It would be nice if we could just define it in one place and have a single source of truth.

client_config.http_api.enable_light_client_server =
cli_args.get_flag("light-client-server");

if cli_args.get_flag("light-client-server") {
client_config.chain.enable_light_client_server = true;
}

// Light client server config.
config.enable_light_client_server = parse_flag(cli_args, "light-client-server");

We are flipping the flag polarity in this PR, but the same issue remains:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant