Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated generation of API docs #209

Closed
laurentsimon opened this issue Jun 13, 2024 · 7 comments · Fixed by #279
Closed

Automated generation of API docs #209

laurentsimon opened this issue Jun 13, 2024 · 7 comments · Fixed by #279
Labels
enhancement New feature or request
Milestone

Comments

@laurentsimon
Copy link
Collaborator

If there's a tool to auto-generate / update documentation based on the doc in the code, that'd be helpful.

@mihaimaruseac @spencerschrock

@spencerschrock
Copy link
Contributor

spencerschrock commented Jun 13, 2024

Since I happened to look at sigstore-python's docs today, would something like their system work?

uses pdoc to generate HTML documentation for the public Python APIs.

Which they run as part of their CI and deploy to github pages at https://sigstore.github.io/sigstore-python/sigstore.html
https://github.com/sigstore/sigstore-python/blob/f9e313eab473503ec688f5a12ed21c81ad9a81f2/.github/workflows/docs.yml

@mihaimaruseac
Copy link
Collaborator

mihaimaruseac commented Jun 13, 2024

This looks great! Let's do it.

I'll add to the v1 release milestone, since it's good to release with some documentation

@spencerschrock
Copy link
Contributor

spencerschrock commented Aug 7, 2024

There is some work towards this done in #279, but there are a few open questions still:

@spencerschrock
Copy link
Contributor

You can see an example of the documentation generated in the action run by downloading the artifact.

@mihaimaruseac
Copy link
Collaborator

This looks good to me, thank you!

I think we might need to reorder the files in the repo as they're not in a good shape for packaging to a wheel. I'll read more about this and experiment to see if we can avoid it, otherwise we need to decide if we wait for #240 or we'd have it rebase again

@spencerschrock
Copy link
Contributor

#279 has been rebased to account for the layout change in #283, and now makes use of hatch.

You can see the latest action run and artifact from the PR.

spencerschrock added a commit to spencerschrock/sigstore-community that referenced this issue Aug 14, 2024
We are hosting library documentation via GitHub Pages, which requires
the feature enabled. For details see
sigstore/model-transparency#209.

Signed-off-by: Spencer Schrock <sschrock@google.com>
haydentherapper pushed a commit to sigstore/community that referenced this issue Aug 14, 2024
We are hosting library documentation via GitHub Pages, which requires
the feature enabled. For details see
sigstore/model-transparency#209.

Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants