Histogram startTimer return value in typescript definition incorrect?

[kevkcc]

Hi,

I was wondering if the following line should return number instead of void.

prom-client/index.d.ts

Line 566 in a88a5c3

startTimer(): (labels?: LabelValues<T>) => void;

I wanted to start a timer on a specific label and am doing something like this in my code:

const end = histogram.labels({ mylabels }).startTimer();
// some stuff
const seconds = end();

But I was surprised to see that this startTimer in the ts definitions doesn't return number and supposedly returns void. In testing, my code works and it still returns a number so I believe it's just a problem with the ts definition.

[a1300]

Looks like this has been fixed in index.d.ts:

prom-client/index.d.ts

Lines 504 to 511 in c1d76c5

	/**
	* Start a timer. Calling the returned function will observe the duration in
	* seconds in the histogram.
	* @param labels Object with label keys and values
	* @return Function to invoke when timer should be stopped. The value it
	* returns is the timed duration.
	*/
	startTimer(labels?: LabelValues<T>): (labels?: LabelValues<T>) => number;

@siimon this issue can be closed