Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emptyUpdate got new semantics with opaleye-0.4 #2

Open
bergmark opened this issue Aug 17, 2015 · 5 comments
Open

emptyUpdate got new semantics with opaleye-0.4 #2

bergmark opened this issue Aug 17, 2015 · 5 comments
Labels

Comments

@bergmark
Copy link
Member

To fix this I think we should scrap runUpdateConst and replace emptyUpdate with another TH-generated function IdUpdate :: To Column R -> To Maybe (To Column R) which could be used like this:

runUpdate table (\r -> (f r) { name = Just $ constant x }) condition

This will make sure that all code that uses it has to get updated.

@bergmark bergmark added the bug label Aug 17, 2015
@hesselink
Copy link
Member

What changed exactly about the semantics of emptyUpdate?

@bergmark
Copy link
Member Author

@hesselink
Copy link
Member

What would runUpdate do? Would it set all columns explicitly to their old values? I think that might be tricky, since they might have been updated, like I mentioned in the opaleye issue.

@c-lewis
Copy link
Contributor

c-lewis commented Nov 6, 2015

Is this issue the reason why the Opaleye dependency has not been changed to allow 0.4?

@bergmark
Copy link
Member Author

bergmark commented Nov 6, 2015

Yep, Everything else should work with 0.4. My suggestion for opaleye is here. I forgot to ping tom again, I'll do that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants