Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra brackets in _translate_sentence_helper #540

Closed
mshannon-sil opened this issue Oct 1, 2024 · 0 comments · Fixed by #544
Closed

Extra brackets in _translate_sentence_helper #540

mshannon-sil opened this issue Oct 1, 2024 · 0 comments · Fixed by #544
Assignees
@mshannon-sil
Labels
bug Something isn't working

Comments

@mshannon-sil
Copy link
Collaborator

In hugging_face_config.py, for the final else statement in _translate_sentence_helper, there's an unnecessary set of brackets around translated_sentence since it's already a list, which is causing experiments to fail when get_token_ids is called.
@mshannon-sil mshannon-sil added the bug Something isn't working label Oct 1, 2024
@mshannon-sil mshannon-sil self-assigned this Oct 1, 2024
@mshannon-sil mshannon-sil linked a pull request Oct 1, 2024 that will close this issue
remove extra brackets #541
Closed
benjaminking pushed a commit that referenced this issue Oct 2, 2024
Fix for #540, issues (+ support for multiple translations) with exper…
11e5baa 
…iment --test
@benjaminking benjaminking mentioned this issue Oct 2, 2024
Merged
benjaminking added a commit that referenced this issue Oct 4, 2024
@benjaminking
Merge pull request #544 from sillsdev/#540_fix_for_experiment_--test
27f7a3b 
Fix for #540, issues (+ support for multiple translations) with exper…
@mshannon-sil mshannon-sil linked a pull request Oct 8, 2024 that will close this issue
Fix for #540, issues (+ support for multiple translations) with exper… #544
Merged
@mshannon-sil mshannon-sil removed a link to a pull request Oct 8, 2024
remove extra brackets #541
Closed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in SIL-NLP Research Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshannon-sil mshannon-sil

Labels
bug Something isn't working
Projects
SIL-NLP Research
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #540, issues (+ support for multiple translations) with exper… sillsdev/silnlp
1 participant
@mshannon-sil