-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate @method docblock tag in CI #171
Labels
Comments
In order for the types to correctly resolve with PHPStan analysis of the existing |
This was referenced Jan 24, 2024
@emteknetnz seems like you're reviewing this so assigning to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Split off from #163
Acceptance criteria
Notes
get_extra_config()
in extensions (see MNT Update @methods on class docblocks silverstripe-framework#11092 (comment))PRs
Note: After merging the below, reassign to Guy so they can add this to packagist and roll it out to all the CMS 5 supported modules
Module Standardiser PRs
Note: For any PR that had outstanding PHPLint issues, I've manually fixed whatever needed to be fixed as a separate commit.
Note that these had to be run against the
5
(or equivalent) branches because the@method
annotation rule doesn't work correctly against the codebase if the generic types aren't available - and those were merged into the5
(or equivalent) branches.The text was updated successfully, but these errors were encountered: