Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto patch release functionality to gha- repos #85

Closed
emteknetnz opened this issue Aug 2, 2023 · 4 comments
Closed

Add auto patch release functionality to gha- repos #85

emteknetnz opened this issue Aug 2, 2023 · 4 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Aug 2, 2023

gha-* repos should have auto patch release functionality after PRs to minor branches are merged.

The patch release functionality is at the tail end of CI. gha-* repos don't use the CI like other modules do.

Option A

  • move the checkgovernance and gaugerelease steps out of ghi-ci and into a new action that can be shared
  • This is probably overkill since we don't really care about things like not tagging for DOC commits or symbiote modules
  • Also if we push an old minor we'll gha-auto-tag will mistakenly make this the v1 tag

Option B

  • Just make a new release every time something is pushed to a minor branch on gha-* and make sure it's restricted it to the silverstripe account
  • This is much simpler and seems better
  • Makes sense to have a new cutdown CI (gha-action-ci) for gha-* modules that simply runs phpunit if it's installed and then does a patch release on push event at the tail end of it

Recommend we go with option B here.

Example runs

** Example run of new gha-action-ci running phpunit + making a patch release:**

** Example of ci.yml using shared gha-gauge-release action:**

PRs

@emteknetnz emteknetnz changed the title Add patch releases functionality to gha- repos Add auto patch releases functionality to gha- repos Aug 2, 2023
@emteknetnz emteknetnz changed the title Add patch releases functionality to gha- repos Add auto patch releases functionality to gha- repos Aug 2, 2023
@emteknetnz emteknetnz changed the title Add auto patch releases functionality to gha- repos Add auto patch release functionality to gha- repos Aug 2, 2023
@GuySartorelli
Copy link
Member

I recommend option A, which is more flexible and reduces doubled-up-code. Surely we want to use the same logic in gaugerelease for GHA as well?

@emteknetnz
Copy link
Member Author

emteknetnz commented Aug 7, 2023

Maybe a combo? - I kind of put "create a new ci for action gha-action-ci" in option B which seems like it's something we want since it simply make rolling this out to all the gha-* repos easier since there's no code duplication, otherwise we'd need to copy paste the patchrelease step on all the repos

The gaugerelease step makes sense to put into its own action to share since it has some good functionality e.g. ensure it's on the latest commit on a branch before tagging

The checkgovernance step probably not at this stage? for gha-* we only care if it's on the silverstripe account whereas checkgovernance was designed for modules on symbiote account etc.

@GuySartorelli
Copy link
Member

PRs merged and tagged.
Reassigning to @emteknetnz to apply the new gha-action-ci to relevant repositories.

@GuySartorelli
Copy link
Member

All PRs merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants