-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto patch release functionality to gha- repos #85
Comments
I recommend option A, which is more flexible and reduces doubled-up-code. Surely we want to use the same logic in gaugerelease for GHA as well? |
Maybe a combo? - I kind of put "create a new ci for action gha-action-ci" in option B which seems like it's something we want since it simply make rolling this out to all the gha-* repos easier since there's no code duplication, otherwise we'd need to copy paste the patchrelease step on all the repos The gaugerelease step makes sense to put into its own action to share since it has some good functionality e.g. ensure it's on the latest commit on a branch before tagging The checkgovernance step probably not at this stage? for gha-* we only care if it's on the silverstripe account whereas checkgovernance was designed for modules on symbiote account etc. |
PRs merged and tagged. |
All PRs merged. |
gha-* repos should have auto patch release functionality after PRs to minor branches are merged.
The patch release functionality is at the tail end of CI. gha-* repos don't use the CI like other modules do.
Option A
v1
tagOption B
Recommend we go with option B here.
Example runs
** Example run of new gha-action-ci running phpunit + making a patch release:**
** Example of ci.yml using shared gha-gauge-release action:**
PRs
The text was updated successfully, but these errors were encountered: