Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VUE_APP_GRAPHQL_TOKEN is still in client code #45

Open
chillu opened this issue Apr 10, 2019 · 0 comments
Open

VUE_APP_GRAPHQL_TOKEN is still in client code #45

chillu opened this issue Apr 10, 2019 · 0 comments
Labels
type/bug

Comments

@chillu
Copy link
Member

chillu commented Apr 10, 2019

We've moved this to zeit.co so we can define the API token on the server, and proxy requests through this server implementation rather than straight to api.github.com. But we're still bundling VUE_APP_GRAPHQL_TOKEN into the app.js, which kinda defeats the purpose of hosting on zeit.co :) @robbieaverill
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chillu @emteknetnz @GuySartorelli