Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure deprecation warnings are only enabled in dev mode. #11054

Closed
GuySartorelli opened this issue Nov 19, 2023 · 1 comment
Closed

Ensure deprecation warnings are only enabled in dev mode. #11054

GuySartorelli opened this issue Nov 19, 2023 · 1 comment
Assignees
@emteknetnz

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Nov 19, 2023 •
edited
Loading

I made a mistake in #11053 where the env check was skipped. It should only be skipped if we know deprecations are disabled - otherwise it should still do the check.

PRs
@GuySartorelli GuySartorelli self-assigned this Nov 19, 2023
This was referenced Nov 19, 2023
Closed
Merged
@GuySartorelli GuySartorelli removed their assignment Nov 19, 2023
@emteknetnz
Copy link
Member

Linked PR has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emteknetnz emteknetnz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli