Member form validator doesn't work

[mfendeksilverstripe]

Module version(s) affected

5.2.22

Description

The form validator for Member edit form doesn't seem to work. This is likely a regression caused by CMS 5 upgrade. Possibly related to the introduction of getCMSCompositeValidator().

How to reproduce

• navigate to the Security section of the CMS
• click on the add new member button
• you should see member edit form which is empty, do not input anything into the form
• click save

Expected behaviour:

I expect to see validation message for at least FirstName and Email as defined in Member_Validator as those two fields are required.

Actual behaviour:

I don't see any validation message and the new user gets created with empty form fields.

Possible Solution

Manually adding the member validator to the composite validator remedies the issue:

class MemberValidatorExtension extends Extension
{
    /**
     * Extension point in @see Member::getCMSCompositeValidator()
     *
     * @param CompositeValidator $compositeValidator
     * @return void
     */
    public function updateCMSCompositeValidator(CompositeValidator $compositeValidator): void
    {
        $owner = $this->getOwner();
        $memberValidator = $owner->getValidator();

        $compositeValidator->addValidator($memberValidator);
    }
}

Additional Context

No response

Validations

• Check that there isn't already an issue that reports the same bug
• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

PRs

• FIX: Member form validator fix. #11395

[GuySartorelli]

PR merged